-
Notifications
You must be signed in to change notification settings - Fork 302
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf: move stylesheet processing into a worker pool
Stylesheets will now be processed using a worker pool This allows up to four stylesheets to be processed in parallel and keeps the main thread available for other build tasks. `NG_BUILD_MAX_WORKERS` environment variable can be used to comfigure the limit of workers used.
- Loading branch information
1 parent
caf0fee
commit 9eaa398
Showing
7 changed files
with
325 additions
and
214 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| import autoprefixer from 'autoprefixer'; | ||
| import { extname, relative } from 'node:path'; | ||
| import { pathToFileURL } from 'node:url'; | ||
| import { workerData } from 'node:worker_threads'; | ||
| import postcss from 'postcss'; | ||
| import postcssUrl from 'postcss-url'; | ||
| import { EsbuildExecutor } from '../esbuild/esbuild-executor'; | ||
| import { generateKey, readCacheEntry, saveCacheEntry } from '../utils/cache'; | ||
| import * as log from '../utils/log'; | ||
| import { CssUrl } from './stylesheet-processor'; | ||
|
|
||
| const { tailwindConfigPath, projectBasePath, browserslistData, targets, cssUrl, styleIncludePaths } = workerData as { | ||
| tailwindConfigPath: string | undefined; | ||
| browserslistData: string; | ||
| targets: string[]; | ||
| projectBasePath: string; | ||
| cssUrl: CssUrl; | ||
| styleIncludePaths: string[]; | ||
| cacheDirectory: string | undefined; | ||
| }; | ||
|
|
||
| let cacheDirectory = workerData.cacheDirectory; | ||
| let postCssProcessor: ReturnType<typeof postcss>; | ||
| let esbuild: EsbuildExecutor; | ||
|
|
||
| interface RenderRequest { | ||
| content: string; | ||
| filePath: string; | ||
| } | ||
|
|
||
| async function render({ content, filePath }: RenderRequest): Promise<string> { | ||
| let key: string | undefined; | ||
| if (cacheDirectory && !content.includes('@import') && !content.includes('@use')) { | ||
| // No transitive deps, we can cache more aggressively. | ||
| key = await generateKey(content, ...browserslistData); | ||
| const result = await readCacheEntry(cacheDirectory, key); | ||
| if (result) { | ||
| result.warnings.forEach(msg => log.warn(msg)); | ||
|
|
||
| return result.css; | ||
| } | ||
| } | ||
|
|
||
| // Render pre-processor language (sass, styl, less) | ||
| const renderedCss = await renderCss(filePath, content); | ||
|
|
||
| // We cannot cache CSS re-rendering phase, because a transitive dependency via (@import) can case different CSS output. | ||
| // Example a change in a mixin or SCSS variable. | ||
| if (!key) { | ||
| key = await generateKey(renderedCss, ...browserslistData); | ||
| } | ||
|
|
||
| if (cacheDirectory) { | ||
| const cachedResult = await readCacheEntry(cacheDirectory, key); | ||
| if (cachedResult) { | ||
| cachedResult.warnings.forEach(msg => log.warn(msg)); | ||
|
|
||
| return cachedResult.css; | ||
| } | ||
| } | ||
|
|
||
| // Render postcss (autoprefixing and friends) | ||
| const result = await postCssProcessor.process(renderedCss, { | ||
| from: filePath, | ||
| to: filePath.replace(extname(filePath), '.css'), | ||
| }); | ||
|
|
||
| const warnings = result.warnings().map(w => w.toString()); | ||
| const { code, warnings: esBuildWarnings } = await esbuild.transform(result.css, { | ||
| loader: 'css', | ||
| minify: true, | ||
| target: targets, | ||
| sourcefile: filePath, | ||
| }); | ||
|
|
||
| if (esBuildWarnings.length > 0) { | ||
| warnings.push(...(await esbuild.formatMessages(esBuildWarnings, { kind: 'warning' }))); | ||
| } | ||
|
|
||
| if (cacheDirectory) { | ||
| await saveCacheEntry( | ||
| cacheDirectory, | ||
| key, | ||
| JSON.stringify({ | ||
| css: code, | ||
| warnings, | ||
| }), | ||
| ); | ||
| } | ||
|
|
||
| warnings.forEach(msg => log.warn(msg)); | ||
|
|
||
| return code; | ||
| } | ||
|
|
||
| async function renderCss(filePath: string, css: string): Promise<string> { | ||
| const ext = extname(filePath); | ||
|
|
||
| switch (ext) { | ||
| case '.sass': | ||
| case '.scss': { | ||
| return (await import('sass')).compileString(css, { | ||
| url: pathToFileURL(filePath), | ||
| syntax: '.sass' === ext ? 'indented' : 'scss', | ||
| loadPaths: styleIncludePaths, | ||
| }).css; | ||
| } | ||
| case '.less': { | ||
| const { css: content } = await ( | ||
| await import('less') | ||
| ).default.render(css, { | ||
| filename: filePath, | ||
| math: 'always', | ||
| javascriptEnabled: true, | ||
| paths: styleIncludePaths, | ||
| }); | ||
|
|
||
| return content; | ||
| } | ||
|
|
||
| case '.css': | ||
| default: | ||
| return css; | ||
| } | ||
| } | ||
|
|
||
| function getTailwindPlugin() { | ||
| // Attempt to setup Tailwind CSS | ||
| // Only load Tailwind CSS plugin if configuration file was found. | ||
| // This acts as a guard to ensure the project actually wants to use Tailwind CSS. | ||
| // The package may be unknowningly present due to a third-party transitive package dependency. | ||
| if (tailwindConfigPath) { | ||
| let tailwindPackagePath; | ||
| try { | ||
| tailwindPackagePath = require.resolve('tailwindcss', { paths: [projectBasePath] }); | ||
| } catch { | ||
| const relativeTailwindConfigPath = relative(projectBasePath, tailwindConfigPath); | ||
| log.warn( | ||
| `Tailwind CSS configuration file found (${relativeTailwindConfigPath})` + | ||
| ` but the 'tailwindcss' package is not installed.` + | ||
| ` To enable Tailwind CSS, please install the 'tailwindcss' package.`, | ||
| ); | ||
| } | ||
|
|
||
| if (tailwindPackagePath) { | ||
| return require(tailwindPackagePath)({ config: tailwindConfigPath }); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| async function initialize() { | ||
| const postCssPlugins = []; | ||
| const tailwinds = getTailwindPlugin(); | ||
| if (tailwinds) { | ||
| postCssPlugins.push(tailwinds); | ||
| cacheDirectory = undefined; | ||
| } | ||
|
|
||
| if (cssUrl !== CssUrl.none) { | ||
| postCssPlugins.push(postcssUrl({ url: cssUrl })); | ||
| } | ||
|
|
||
| postCssPlugins.push( | ||
| autoprefixer({ | ||
| ignoreUnknownVersions: true, | ||
| overrideBrowserslist: browserslistData, | ||
| }), | ||
| ); | ||
|
|
||
| postCssProcessor = postcss(postCssPlugins); | ||
|
|
||
| esbuild = new EsbuildExecutor(); | ||
|
|
||
| // Return the render function for use | ||
| return render; | ||
| } | ||
|
|
||
| /** | ||
| * The default export will be the promise returned by the initialize function. | ||
| * This is awaited by piscina prior to using the Worker. | ||
| */ | ||
| export default initialize(); |
Oops, something went wrong.