Skip to content

fix: Address Alpine bug and shell linter warnings #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Aug 2, 2023

  • Replace -n with -f in Alpine Linux conditional check
  • Ensure shell variables are properly quoted
  • Set variable before exporting to ensure it properly fails (if it fails)
  • Replace obsolete -o conditional check with ||

* Replace `-n` with `-f` in Alpine Linux conditional check
* Ensure shell variables are properly quoted
* Set variable before exporting to ensure it properly fails (if it fails)
* Replace obsolete `-o` conditional check with `||`
@thresheek thresheek merged commit 2879b26 into nginx:master Aug 2, 2023
@alessfg alessfg deleted the only-fixes branch August 2, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants