Skip to content

Add lint workflow #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martialonline merged 4 commits into from
Oct 21, 2020
Merged

Add lint workflow #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c56700b
Add lint workflow
martialonline Oct 21, 2020
4a21c40
Add lint args
martialonline Oct 21, 2020
b6aa26b
Remove ignore-paths
martialonline Oct 21, 2020
70d721c
Update lint version to 1.29
martialonline Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Lint

on:
pull_request:
branches:
- master
types:
- opened
- reopened
- synchronize

defaults:
run:
shell: bash

env:
GOLANGCI_VERSION: 1.29
GOLANGCI_TIMEOUT: 10m0s

jobs:

lint:
name: Lint
runs-on: ubuntu-18.04
steps:
- name: Checkout Repository
uses: actions/checkout@v2
- name: Lint Code
uses: golangci/golangci-lint-action@v2
with:
version: 'v${{ env.GOLANGCI_VERSION }}'
args: --timeout ${{ env.GOLANGCI_TIMEOUT }} --issues-exit-code=0 ./client/...
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ DOCKER_NGINX_PLUS?=nginx-plus
DOCKER_NGINX_PLUS_HELPER?=nginx-plus-helper

GOLANG_CONTAINER=golang:1.15
GOLANGCI_CONTAINER=golangci/golangci-lint:v1.27-alpine
GOLANGCI_CONTAINER=golangci/golangci-lint:v1.29-alpine

export TEST_API_ENDPOINT=http://$(DOCKER_NGINX_PLUS):8080/api
export TEST_API_ENDPOINT_OF_HELPER=http://$(DOCKER_NGINX_PLUS_HELPER):8080/api
Expand Down