Remove fs.promises.readSync.

[jo-carter]

njs/external/njs_fs_module.c

Line 400 in 606ceb2

.name.string = njs_str("readSync"),

All other promise fs functions have their "Sync" postfix removed. Is leaving it in for readSync intentional?

njs/external/njs_fs_module.c

Line 1334 in 606ceb2

.name.string = njs_str("read"),

I see there is also a fs.promises.read function that appears to be identical.

[xeioex]

Hi @jo-carter,

All other promise fs functions have their "Sync" postfix removed. Is leaving it in for readSync intentional?

There is no fs.promises.read() in nodejs. So, read() is unlike other methods.
readSync() should be removed from fs.promisesthough, thanks.

I see there is also a fs.promises.read function that appears to be identical.

Actually it is not fs.promises.read but filehandle.read.
We have filehandle partially implemented.

While they share the same C function, their behaviour is different depending on the magic8 constant.

[jo-carter]

Hi @xeioex

There is no fs.promises.read() in nodejs. So, read() is unlike other methods.
readSync() should be removed from fs.promisesthough, thanks.

Ah yes you're right, I forgot about that quirk in NodeJS's non-promise fs API.

Actually it is not fs.promises.read but filehandle.read.
We have filehandle partially implemented.

Yes, I also missed that this was for filehandles while scrolling through :)