Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Include unitctl in our Homebrew and Linux packages #1281

Open
Tracked by #1276
javorszky opened this issue May 20, 2024 · 6 comments
Open
Tracked by #1276

CLI: Include unitctl in our Homebrew and Linux packages #1281

javorszky opened this issue May 20, 2024 · 6 comments
Assignees

Comments

@javorszky
Copy link
Contributor

unitctl should also be built and published to the linux package managers that we build unit packages for, as well as homebrew

@avahahn
Copy link
Contributor

avahahn commented Sep 25, 2024

@thresheek Please correct me if I am wrong, but this is complete yes?

@thresheek
Copy link
Member

We have unitctl in homebrew (downloaded from GH releases), but not in the packages.

I'm not sure if the approach taken in homebrew - downloading binary packages without building those - is applicable to Linux packages where we compile it all from scratch. This needs to be figured out.

@callahad
Copy link
Collaborator

When we include unitctl in packages, we probably should build it from scratch if possible. However, it's an end-user tool, so for the next release or two it's fine to direct people to manually grab a binary from GitHub.

@callahad
Copy link
Collaborator

FWIW, Rust will become a build requirement once we merge OpenTelemetry support for 1.34 (targeting late January 2025 for release), so work here should also get reused for that :)

@thresheek
Copy link
Member

Rust is already a build requirement due to wasm modules we ship in the binary packages; same for Java / maven. I think it's just a matter of spending time on implementing the actual build process in packages and testing it on the supported OSes.

@callahad
Copy link
Collaborator

callahad commented Oct 7, 2024

Ah, yes, of course. Sorry, that completely skipped my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants