Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTTP2 from annotations on ingress #152

Closed
woopstar opened this issue Jun 23, 2017 · 1 comment
Closed

Remove HTTP2 from annotations on ingress #152

woopstar opened this issue Jun 23, 2017 · 1 comment

Comments

@woopstar
Copy link
Contributor

If you enable HTTP2 on one ingress, it will automatic be enabled on all server blocks on the same ip. So if one ingress has HTTP2 enabled, then it is auto enabled for all other server blocks.

So maybe it only makes sense to configure it globally in the config map. Either it's on, or it's off?
@pleshakov
Copy link
Contributor

@woopstar you're right. it doesn't make sense to have this annotation.

@pleshakov pleshakov mentioned this issue Jul 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pleshakov @woopstar