Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance: Set the Address field in Gateway Status #370

Closed
Tracked by #305
, #612
...
kate-osborn opened this issue Jan 13, 2023 · 0 comments · Fixed by #638
Closed
Tracked by #305
, #612
...

Conformance: Set the Address field in Gateway Status #370

kate-osborn opened this issue Jan 13, 2023 · 0 comments · Fixed by #638
Assignees
@sjberman
Labels
area/gateway/core Relates to all Core features of Gateway conformance Relates to passing Gateway API conformance tests enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Milestone
v0.4.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Jan 13, 2023 •
edited by mpstefan
Loading

The conformance tests expect the addresses field in the GatewayStatus to be set by the controller. The tests use the first IP address in addresses to send requests to the data plane to verify the routes are working properly.

Since this issue aims to unblock the conformance tests, we will use the Pod IP of the NKG Pod only.

Acceptance Criteria:

  • Set the GatewayStatus.addresses field to the Pod IP of the NKG Pod.
  • Verify the conformance test helper WaitForGatewayAddress succeeds.
  • Update the gateway API compatibility doc
@kate-osborn kate-osborn mentioned this issue Jan 13, 2023
Closed
@pleshakov pleshakov added blocked Blocked by other issue enhancement New feature or request area/gateway/core Relates to all Core features of Gateway and removed blocked Blocked by other issue proposal labels Apr 7, 2023
@pleshakov pleshakov added this to the v1.0.0 milestone Apr 7, 2023
@pleshakov pleshakov mentioned this issue Apr 7, 2023
Closed
@pleshakov pleshakov modified the milestones: v1.0.0, v0.4.0 Apr 26, 2023
@kate-osborn kate-osborn mentioned this issue May 1, 2023
Closed
@kate-osborn kate-osborn added the refined Requirements are refined and the issue is ready to be implemented. label May 3, 2023
@sjberman sjberman self-assigned this May 10, 2023
@sjberman sjberman moved this from 🆕 New to 🔖 To Do in NGINX Gateway Fabric May 10, 2023
@pleshakov pleshakov added the conformance Relates to passing Gateway API conformance tests label May 10, 2023
@mpstefan mpstefan mentioned this issue May 10, 2023
Closed
@sjberman sjberman moved this from 🔖 To Do to 🏗 In Progress in NGINX Gateway Fabric May 11, 2023
@sjberman sjberman mentioned this issue May 11, 2023
Merged
6 tasks
@sjberman sjberman moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric May 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
area/gateway/core Relates to all Core features of Gateway conformance Relates to passing Gateway API conformance tests enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Set gateway Pod IP as GatewayStatus address sjberman/nginx-gateway-fabric
3 participants
@pleshakov @sjberman @kate-osborn