Report proper Conditions in status of HTTPRoute and Gateway when GatewayClass is invalid or doesn't exist #576
+813
−862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If GatewayClass is invalid or doesn't exist: - For Gateway Listeners: NKG will make every listener invalid and report Accepted condition with status False and reason NoValidGatewayClass in every listener status. - For HTTPRoutes: An HTTPRoute will not be able to attach to any listener, because they will be invalid. This is already handled: NKG will report Accepted condition with status False and reason InvalidListener. Fixes #307
pleshakov
commented
Apr 13, 2023
pleshakov
commented
Apr 13, 2023
pleshakov
commented
Apr 13, 2023
kate-osborn
reviewed
Apr 17, 2023
kate-osborn
approved these changes
Apr 17, 2023
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1)
Refactor listener validation
This prepares the codebase for an easy implementation in (2)
(2)
If GatewayClass is invalid or doesn't exist:
report Accepted condition with status False and reason
NoValidGatewayClass in every listener status.
listener, because they will be invalid. This is already handled: NKG
will report Accepted condition with status False and reason
InvalidListener.
Fixes #307