This repository was archived by the owner on May 24, 2023. It is now read-only.
Make operator install KIC CRDs from manifests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
reviewed
Jul 14, 2020
pkg/controller/nginxingresscontroller/nginxingresscontroller_controller.go
Outdated
Show resolved
Hide resolved
Dean-Coakley
approved these changes
Jul 14, 2020
pleshakov
approved these changes
Jul 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We used to create the CRDs from the Operator, the only difference is that now, we bundle the full manifests instead of creating them from go code.
This will make sure all our KIC CRDs are working for the given version of the operator-kic relationship, and will also have the openapi schema validation that was not present before.
Downsides