Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prmp 1120 - NRL Lambda and SQS #205

Merged
merged 11 commits into from
Nov 15, 2024
Merged

Prmp 1120 - NRL Lambda and SQS #205

merged 11 commits into from
Nov 15, 2024

Conversation

jack-nhs
Copy link
Contributor

@jack-nhs jack-nhs commented Nov 4, 2024

No description provided.

@NogaNHS NogaNHS changed the title Prmp 1120 - Creates SQS for NRL attributes Prmp 1120 - NRL Lambda and SQS Nov 5, 2024
is_gateway_integration_needed = false
is_invoked_from_gateway = false

depends_on = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implicit.

namespace = "AWS/Lambda"
alarm_actions = [module.manage-nrl-pointer-alarm-topic.arn]
ok_actions = [module.manage-nrl-pointer-alarm-topic.arn]
depends_on = [module.manage-nrl-pointer-lambda, module.manage-nrl-pointer-alarm-topic]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are implicit.

]
})

depends_on = [module.manage-nrl-pointer-lambda, module.sns_encryption_key]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implicit.

}
}

depends_on = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit

chrisbloe-nhse
chrisbloe-nhse previously approved these changes Nov 8, 2024
Copy link

@chrisbloe-nhse chrisbloe-nhse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes :) All approved.

Copy link

@robg-test robg-test Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lambda may need to be bumped up from the default memory setting due to it interacting with a 3rd Party API as well as SSM

Copy link
Contributor

@AndyFlintNHS AndyFlintNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes since last approval are a rebase from PRMP-1185 - will approve on this basis.

@NogaNHS NogaNHS merged commit 54573ab into main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants