diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e5edaa80..7b5bbba8c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Change "Contact us" in the footer link examples to "Give us feedback" ([PR 972](https://github.com/nhsuk/nhsuk-frontend/pull/972)) - Remove the pattern from the date input component +- Adjust errorSummary bottom margin ([PR 973](https://github.com/nhsuk/nhsuk-frontend/pull/973)) - Fix height of select component in Safari ([PR 987](https://github.com/nhsuk/nhsuk-frontend/pull/987)) - Set minimum width of select component ([PR 987](https://github.com/nhsuk/nhsuk-frontend/pull/987)) diff --git a/packages/components/error-summary/_error-summary.scss b/packages/components/error-summary/_error-summary.scss index 25bd9bcc6..1467cb703 100644 --- a/packages/components/error-summary/_error-summary.scss +++ b/packages/components/error-summary/_error-summary.scss @@ -9,7 +9,13 @@ .nhsuk-error-summary { @include nhsuk-responsive-padding(4); - @include nhsuk-responsive-margin(8, "bottom"); + + // Not using responsive spacing as we want smaller margin on mobile + margin-bottom: nhsuk-spacing(5); + + @include govuk-media-query($from: tablet) { + margin-bottom: nhsuk-spacing(7); + } border: $nhsuk-border-width-mobile solid $nhsuk-error-color; diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_0_iPhone_5_SE.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_0_iPhone_5_SE.png index 49a83835b..7694c73fd 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_0_iPhone_5_SE.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_0_iPhone_5_SE.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_1_iPhone_6-8.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_1_iPhone_6-8.png index 6d313a836..61d4067ad 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_1_iPhone_6-8.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_1_iPhone_6-8.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_2_iPad.png index 7ccc45e0b..8edd1d77d 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_2_iPad.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_2_iPad.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_3_Surface_iPad_Pro.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_3_Surface_iPad_Pro.png index c438a8264..185409e2e 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_3_Surface_iPad_Pro.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_3_Surface_iPad_Pro.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_0_iPhone_5_SE.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_0_iPhone_5_SE.png index b807fd98f..254c02ba0 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_0_iPhone_5_SE.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_0_iPhone_5_SE.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_1_iPhone_6-8.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_1_iPhone_6-8.png index 3f9a2b386..7e50c2a5a 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_1_iPhone_6-8.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_1_iPhone_6-8.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_2_iPad.png index 013791241..1a1cb1fe7 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_2_iPad.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_2_iPad.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_3_Surface_iPad_Pro.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_3_Surface_iPad_Pro.png index c76b46c11..67b7a3a0e 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_3_Surface_iPad_Pro.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_3_Surface_iPad_Pro.png differ