Fix bug with indentation of nested parent rows #1839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This fixes a bug I found where the indentation of nested parent rows can sometimes be incorrect, particularly when the order of rows changes (such as when sorting a column) in a way that changes the nesting level that is set on a
nimble-table-row
element that is getting reused during a binding update.The problematic binding was this condition in the table row's template:
x.isParentRow && x.nestingLevel > 0
. That statement is volatile, but it cannot be marked as such in the template. Therefore, I moved the evaluation into a getter namedisNestedParent
that could be marked as@volatile
.👩💻 Implementation
See Rationale section above
🧪 Testing
Manually tested in storybook with a problematic set of data that I found the problem with
✅ Checklist