Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made all the modifications required to have a standalone examples package #171

Merged
merged 3 commits into from
May 5, 2021

Conversation

zszilagy
Copy link
Collaborator

@zszilagy zszilagy commented May 4, 2021

What does this Pull Request accomplish?

Creates a standalong nipkg file for the Scripting API Examples project.

Why should this Pull Request be merged?

Currently the examples doesn't come in a separate nipkg.

What testing has been done?

n/a. Will be verified after the first PR installers are built.

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Post-Build Action.vi.png

capture

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Post-Build Action.vi.png

capture

control_scripting_examples Outdated Show resolved Hide resolved
@PaulDanH
Copy link
Collaborator

PaulDanH commented May 4, 2021

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Post-Build Action.vi.png
capture

I think this setup will generate a nested structures like:

  • "Scripting Examples/Scripting API Examples/..." in the Destination Path.

Shouldn't we use the same mechanism like for the other assets without adding the extra code for path manipulation?

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Post-Build Action.vi.png

capture

Copy link
Collaborator

@PaulDanH PaulDanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my above comment.

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Copy Scripting .LLB to LV Addons dir.vi.png

capture

Post-Build Action.vi.png

capture

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Copy Scripting .LLB to LV Addons dir.vi.png

capture

Post-Build Action.vi.png

capture

@zszilagy zszilagy requested a review from PaulDanH May 5, 2021 08:19
@PaulDanH PaulDanH merged commit 7596cb4 into ni:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants