Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove binary / util paths from monkeypatching #287

Closed
philipmac opened this issue Aug 29, 2023 · 1 comment
Closed

remove binary / util paths from monkeypatching #287

philipmac opened this issue Aug 29, 2023 · 1 comment

Comments

@philipmac
Copy link
Member

all utility paths can be defined in .env files on machine to test / run
There's no need to have >1 path for test vrs run
which does not really address this issue
The developer should initialize every utility one time, in env files. If these files are not existing a preflight check in the test should warn / fail.

@mbopfNIH
Copy link
Collaborator

Agreed. Using .env files for paths is better than util.which, which also didn't work on HPC. In the case of executables not being available, a "fail fast" approach is probably warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants