Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers #284

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Containers #284

merged 3 commits into from
Aug 25, 2023

Conversation

annshress
Copy link
Collaborator

@annshress annshress commented Aug 24, 2023 •
edited
Loading

Addresses #275

Changes

  • Adds Dockerfile to run pipeline in the containers

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

@annshress annshress force-pushed the feature/containers branch 2 times, most recently from 6532fcd to 991aabf Compare August 25, 2023 16:53
philipmac
philipmac approved these changes Aug 25, 2023
View reviewed changes
docs/source/development.rst Show resolved Hide resolved
@annshress annshress marked this pull request as ready for review August 25, 2023 17:31
@philipmac philipmac merged commit 3b11993 into main Aug 25, 2023
@philipmac philipmac deleted the feature/containers branch August 25, 2023 19:59
@annshress annshress mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipmac philipmac philipmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annshress @philipmac