Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against newer health check module #59

Open
nicholaschiasson opened this issue Dec 9, 2020 · 0 comments
Open

Test against newer health check module #59

nicholaschiasson opened this issue Dec 9, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nicholaschiasson
Copy link
Owner

I think we should try to prefer this newer health check module. It is noted that it is still in development, however, it has support for prometheus output and also nginx stream module.

Update the ./.github/actions/nginx-module-toolbox/Dockerfile and ./scripts/build.sh files to make nginx build against this healthcheck module rather than the current one. One thing to be careful of is the patches. I know this new repo uses a weird naming convention for those patches...
@nicholaschiasson nicholaschiasson added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicholaschiasson