-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead #52
Comments
Looks like there's a PR |
Your plugin is broken on Webpack 5 because of this warning @nickjj |
Believe so, but I switched to @5kyc0d3r's fork: PS, thank you for the work on these |
Yeah I would switch to a different library. I really should archive this project as I haven't used it in a very long time and I don't like seeing so many people try to use it and then it blows up since it's not compatible with newer versions of Webpack. My personal opinion is that the md5 hashing of files should really be controlled by whatever web framework you use since your web framework's template system needs a manifest file in the end to do the look up. You need both halves (the manifest file and template helpers), so you might as well do it all with your web framework since having a manifest file get generated with webpack isn't enough on its own. This is what Rails, Django, Phoenix and now Flask does (well, with Flask I wrote an extension to do it). |
The text was updated successfully, but these errors were encountered: