Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead #52

Open
braco opened this issue Sep 10, 2019 · 5 comments

Comments

@braco
Copy link

braco commented Sep 10, 2019

(node:58259) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
    at Walker.file (manifest-revision-webpack-plugin/index.js:149:30)

node:58259) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
    at ManifestRevisionPlugin.apply (manifest-revision-webpack-plugin/index.js:178:14)
@braco
Copy link
Author

braco commented Sep 11, 2019

Looks like there's a PR

#48

@braco
Copy link
Author

braco commented Dec 10, 2019

Your plugin is broken on Webpack 5 because of this warning @nickjj

@nickjj
Copy link
Owner

nickjj commented Dec 10, 2019

@braco does #48 fix this?

@braco
Copy link
Author

braco commented Dec 12, 2019

Believe so, but I switched to @5kyc0d3r's fork:
https://github.com/5kyc0d3r/flask-webpack-fork
that uses
https://github.com/danethurber/webpack-manifest-plugin
Might be a good migration recommendation if you want to let these projects go?

PS, thank you for the work on these

@nickjj
Copy link
Owner

nickjj commented Dec 12, 2019

Yeah I would switch to a different library. I really should archive this project as I haven't used it in a very long time and I don't like seeing so many people try to use it and then it blows up since it's not compatible with newer versions of Webpack.

My personal opinion is that the md5 hashing of files should really be controlled by whatever web framework you use since your web framework's template system needs a manifest file in the end to do the look up.

You need both halves (the manifest file and template helpers), so you might as well do it all with your web framework since having a manifest file get generated with webpack isn't enough on its own.

This is what Rails, Django, Phoenix and now Flask does (well, with Flask I wrote an extension to do it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants