Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events count fix #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gaffel85
Copy link

shoudlPromptForRating did stop checking events count when uses count did reach its goal.
By changing AND to OR both expression will be checked.

shoudlPromptForRating did stop checking events count when uses count did reach its goal.
By changing AND to OR both expression will be checked.
@nicklockwood
Copy link
Owner

This isn't actually a bug, but a design decision. Arguably it was a bad decision, but applying this fix as it stands actually breaks the default functionality, since usesUntilPrompt defaults to 10, so any app that doesn't log any events will never present the notification.

If you want to prevent notifications unless both use count AND event count have been reached, you can add this additional check using the iRate delegate.

@nicklockwood
Copy link
Owner

I'll leave this open for now - I may consider changing this behaviour at some point but it will need some other changes to be made as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants