Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support codeship docker environment variables #131

Conversation

mrcrgl
Copy link
Contributor

@mrcrgl mrcrgl commented Jun 26, 2016

Hi @nickmerwin

Codeship has published its new Docker implementation with some helpful environment variables. I think many people who're using docker will be glad to remove the .git files from the container.

[https://codeship.com/documentation/docker/steps/#build-environment](Codeship Docker configuration)

Marc

@coveralls
Copy link

coveralls commented Jun 26, 2016

Coverage Status

Coverage increased (+0.07%) to 94.828% when pulling 2fb137e on mrcrgl:feature/support-codeship-docker-environment into 57db719 on nickmerwin:master.

@mrcrgl
Copy link
Contributor Author

mrcrgl commented Jul 18, 2016

Hi @nickmerwin,

would you please have a look at my change? The failing doesn't seem to belong to my change The command "make test-coveralls" exited with 2. (missing repo token).

  • Marc

@ash14
Copy link

ash14 commented Sep 14, 2016

Is there an update on this? I'm seeing "Unknown Commit Message" for all builds, so I'd like to have this PR merged in as well.

@mrcrgl
Copy link
Contributor Author

mrcrgl commented Sep 15, 2016

@nickmerwin would you please have a look at this PR?

@nickmerwin nickmerwin merged commit 272e662 into nickmerwin:master Sep 15, 2016
@nickmerwin
Copy link
Owner

Thank you @mrcrgl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants