Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept does not continue in the browser with 22.2.0/21.0.5 #551

Closed
heliohenriques opened this issue Oct 1, 2021 · 30 comments · Fixed by nextcloud/server#29056
Closed

Accept does not continue in the browser with 22.2.0/21.0.5 #551

heliohenriques opened this issue Oct 1, 2021 · 30 comments · Fixed by nextcloud/server#29056

Comments

@heliohenriques
Copy link

Hi,
Today after update to the version 22.2.0, the 2FA APP Notification stop work.
The issue happened with different account's and different users.
Some phones don't receive notification, and some receive, but after approval nothing happen.
The same with approval by webApp notification (after approval nothing happen).

The login keeps waiting permission, but nothing happen.

No logs were created.

Server configuration

**Operating system: Debian 10
**Web server: Apache
**Database: SQL
**PHP version: 8.0
**Nextcloud version: 22.2.0

Thank you for the help

@nickvergessen
Copy link
Member

So there is a known issue with iOS: #468

@tonyskilton
Copy link

I'm seeing the same behaviour.

Notification is generated on the Android app, and is showing up in the Windows and Linux desktop clients.
Clicking approve on any of them doesn't progress the login, it just stays on the "Please accept the request" screen.

This has been since updating to 22.2.0

Nothing appears in the log.

Server configuration
**Operating system: openSUSE Tumbleweed
**Web server: Apache
**Database: MariaDB
**PHP version: 7.4
**Nextcloud version: 22.2.0

@freddresken
Copy link

Same here on OpenSUSE Leap 15.3. Only OTP seem to function properly.

@schnello
Copy link

schnello commented Oct 2, 2021

Same here. No Log.
PhP 8.0.11
Nextcloud version: 22.2.0
Ubuntu Server

@Seneliux
Copy link

Seneliux commented Oct 3, 2021

Ubuntu 20.04, nginx, php-fpm 8.x
nginx shows that there are many GET requests, and only stops when canceling login. Same before Aprove, and after approving login. Even after canceling login via notification nothing changing. Requests stops if cancel login at login prompt (not via notification)
NC "ignoring" Accept or Cancel login and inifinity generates requests.

IP - - [03/Oct/2021:20:09:02 +0200] "GET /ocs/v2.php/apps/twofactor_nextcloud_notification/api/v1/poll/TOKEN HTTP/2.0" 303 0 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36" "-"
IP - - [03/Oct/2021:20:11:33 +0200] "GET /login/selectchallenge?redirect_url=/ocs/v2.php/apps/twofactor_nextcloud_notification/api/v1/poll/TOKEN HTTP/2.0" 200 7387 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36" "-"
IP - - [03/Oct/2021:20:13:02 +0200] "GET /login/selectchallenge?redirect_url=/ocs/v2.php/apps/twofactor_nextcloud_notification/api/v1/poll/TOKEN HTTP/2.0" 200 7385 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36" "-"

@nickvergessen
Copy link
Member

The reason is this security hardening:
nextcloud/server#28725

@nickvergessen
Copy link
Member

This patch in Nextcloud itself (not the app) should solve the problem:
https://github.com/nextcloud/server/pull/29056.diff

See https://docs.nextcloud.com/server/latest/admin_manual/issues/applying_patch.html for a manual how to apply the patch

@DecaTec
Copy link

DecaTec commented Oct 4, 2021

This patch in Nextcloud itself (not the app) should solve the problem: https://github.com/nextcloud/server/pull/29056.diff

Yes, this seems to work.
Thank you!

@heliohenriques
Copy link
Author

This patch in Nextcloud itself (not the app) should solve the problem: https://github.com/nextcloud/server/pull/29056.diff

See https://docs.nextcloud.com/server/latest/admin_manual/issues/applying_patch.html for a manual how to apply the patch

It works.
Thank you!

@franconianmetal
Copy link

patch works, thx

@nickvergessen nickvergessen changed the title Issue with NC v.22.2.0 After accept does not continue in the browser with 22.2.0 and 21.0.5 Oct 5, 2021
@nickvergessen nickvergessen pinned this issue Oct 5, 2021
@kroerig
Copy link

kroerig commented Oct 6, 2021

This patch in Nextcloud itself (not the app) should solve the problem: https://github.com/nextcloud/server/pull/29056.diff

Yes, this seems to work. Thank you!

There is no psalm.xml in my installation and patch asks for this file.

@nickvergessen
Copy link
Member

you can ignore that part.

@nickvergessen nickvergessen changed the title After accept does not continue in the browser with 22.2.0 and 21.0.5 Accept does not continue in the browser with 22.2.0/21.0.5 Oct 7, 2021
@resoli
Copy link

resoli commented Oct 8, 2021

Patch fixes for me (NC 21.0.5) as well. Thanks.

@HansHuckebein7
Copy link

How to patch a snap installation on a read-only filesystem?

@webermax
Copy link

webermax commented Oct 11, 2021

Works for 21.0.5. Thank you!

sudo -u www-data wget https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/29056.diff
sudo -u www-data git apply --reject 29056.diff

...works for 22.2.0, too.

@gabriel-joy
Copy link

Works for 21.0.5. Thank you!

sudo -u www-data wget https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/29056.diff sudo -u www-data git apply --reject 29056.diff

Best answer!

@skito
Copy link

skito commented Oct 18, 2021

The issue continues with Nextcloud version 22.2.0 and plugin version 3.2.1. Snap installation on Ubuntu 20.04.

@nickvergessen
Copy link
Member

Yeah it's only fixed in 22.2.1

@pvanthony
Copy link

There is no psalm.xml in my installation and patch asks for this file.

Me too but the patch works.
Did the command from #551 (comment)
This is for version 22.2.0

@webermax
Copy link

There is no psalm.xml in my installation and patch asks for this file.

Me too but the patch works. Did the command from #551 (comment) This is for version 22.2.0

--reject applies partly: https://git-scm.com/docs/git-apply

@pvanthony
Copy link

Me too but the patch works. Did the command from #551 (comment) This is for version 22.2.0

--reject applies partly: https://git-scm.com/docs/git-apply

Cool. Just read the doc at the link above. Thank you for sharing the link to the documentation.

@Webbeh
Copy link

Webbeh commented Nov 4, 2021

This patch worked for me today as well. Nextcloud 22.2.0.

Thank you !

@meonkeys
Copy link

How to patch a snap installation on a read-only filesystem?

Similar question: how would I patch Nextcloud 22.2.0 run via Docker compose? I'm using the Docker image label nextcloud:22. I'm guessing something could be added to docker-compose.yml to run [some of] the shell commands mentioned by others, or that I'd need to build a custom image.

Or wait for the next minor release... Will Nextcloud server 22.2.1 include the fix?

@nickvergessen
Copy link
Member

Will Nextcloud server 22.2.1 include the fix?

yes, and it was released yesterday. So whenever the docker people pick it up you have it

@Darkmagister
Copy link

i have nextcloud 22.2.1 but i still have this issue, i don't want to apply the patch manually because it would need to be done every update, maybe 22.2.2 will have it ???

@nickvergessen
Copy link
Member

22.2.2 is already there and the patch is included in 22.2.1 already.
If you still have an issue it might be something else

@meonkeys

This comment has been minimized.

@Darkmagister
Copy link

Darkmagister commented Nov 13, 2021

22.2.2 is already there and the patch is included in 22.2.1 already. If you still have an issue it might be something else

I will wait for docker update of image to 22.2.2 to be sure but with 22.2.1 i still have this issue, i accept the login from the notification on the app but the page on the computer doesn't refresh or anything

--- UPDATE
i've updated the docker with 22.2.2 but still i try to login, i select nextcloud notification, in the app i click approve but still the page doesn't refresh and login, and i don't see any strange log, do you have any suggestion to gather more information about this?

@meonkeys
Copy link

Verified fixed / working as expected with nextcloud 22.2.3 (using image from Docker Hub).

@1989gironimo
Copy link

I'm running 22.2.3 and it's still not working, what's needed to analyze this further?

@nickvergessen nickvergessen unpinned this issue Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.