Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please not set the HOSTNAME environment variable in the Dockerfile? #167

Open
avbenavides opened this issue Aug 8, 2024 · 0 comments

Comments

@avbenavides
Copy link

This is a request.
Can you please not set the HOSTNAME environment variable in the Dockerfile?
A non-written convention in the K8s and Docker world is that the HOSTNAME environment variable value is the container or host ID. The netshoot Dockerfile breaks this convention by setting the HOSTNAME variable to "netshoot".
The uniqueness of HOSTNAME is used (that I've seen) for:

  • Identifying the container in logs
  • Uniqueness in metrics
  • Other scripting that requires uniqueness that survives reboots/restarts (i.e. depending on the life-cycle, the container may be restarted in case of crash/fail exit code).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant