Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining carbs cap allows 'illegal' value #189

Closed
LiroyvH opened this issue May 14, 2024 · 3 comments · Fixed by #232
Closed

Remaining carbs cap allows 'illegal' value #189

LiroyvH opened this issue May 14, 2024 · 3 comments · Fixed by #232
Assignees
Labels
bug Something isn't working not-planned stale

Comments

@LiroyvH
Copy link
Contributor

LiroyvH commented May 14, 2024

According to https://docs.diy-trio.org/en/latest/settings/configuration/preferences/othersettings.html#remaining-carbs-cap a value of 90 is the absolute minimum for "Remaining Carbs Cap" in Preferences (all the wayyyy at the bottom :)). However, the app allows you to set a value far lower than that. If the limit is supposed to be 90 at the lowest in accordance with the docs, not accepting lower values in that field may be a good idea.

@dsut4392
Copy link

I do not agree that values below 90 should be 'illegal'. The purpose of this variable is to set a limit on the maximum amount of carbs allowed to remain after 4h.
Apart from the docs saying so, can anyone articulate a reason why the remaining carbs cap shouldn't be set lower than 90? A significant proportion of people will never have a COB anywhere near 90 even right after a meal, let alone 4 hours later, so for those people setting 90 as a hard limit for this variable means it serves no purpose at all. E.g. my son typically consumes less than 90g carbs per day.
From determine-basal.js, line 1243-1244:
var remainingCarbs = Math.max(0, meal_data.mealCOB - totalCA - meal_data.carbs*remainingCarbsIgnore);
remainingCarbs = Math.min(remainingCarbsCap,remainingCarbs);

[the infotext in PreferencesEditorStateModel.swift is also incorrect, I will log an issue report]

@Sjoerd-Bo3
Copy link
Contributor

hey 👋 - silence for 30 days 🤐 ... anybody? triage is required!

Copy link

closed 📴 because silencio 🤫 since an additional 14 days after staleness 📠

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working not-planned stale
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants