Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NS Settings Import: Set median of lower and upper correction range bound when importing Loop settings #252

Closed
dnzxy opened this issue May 31, 2024 · 1 comment · Fixed by #253
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dnzxy
Copy link
Contributor

dnzxy commented May 31, 2024

Is your feature request related to a problem? Please describe.

When importing settings from NS that were uploaded to NS from Loop, there are upper and lower correction range limits stored in NS. This is downloaded to Trio, but the lower end is set as target, as Trio does not have a correction or target range.

Describe the solution you'd like

Do not set the lower bound of the correction range as target, but the median of upper and lower.

Additional context

This came up when testing PR #249 which solves issue #245

User Impact

Ensures a safer Trio target, as Loop already aims to get to "center" of correction range; thus this is the target new Trio users will want to use upon importing their settings.

@Sjoerd-Bo3
Copy link
Contributor

@kskandis This is the one I was talking about. All yours if you want to!

@dnzxy dnzxy added good first issue Good for newcomers and removed needs-triage labels Jun 4, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants