-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of Nightscout's provided display of Carbs + Protein + Fat in graph for meal entries #289
Labels
Comments
aug0211
added a commit
to aug0211/aug0211-Trio
that referenced
this issue
Jun 9, 2024
…otein in graph - Resolves (Trio issue nightscout#289)[nightscout#289] - Implements Nightscout's provided graph display for fat and protein in meal entries - Trio had partially implemented this but did not pass fat and protein values to Nightscout (it dropped them but carried carbs) - This PR follows the identical pattern used for carbs and carries fat and protein values along for NS to display
bjornoleh
added a commit
that referenced
this issue
Jun 9, 2024
Resolve issue #289: implement NS-provided display of fat/protein
Resolved by #290 |
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this issue
Aug 1, 2024
* All occurances of "Non-Pump" or "nonPump" in texts and code changed to "External" * Removed label "Automatic" for SMBs in history
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this issue
Aug 1, 2024
* All occurances of "Non-Pump" or "nonPump" in texts and code changed to "External" * Removed label "Automatic" for SMBs in history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Nightscout provides functionality to display carbs, protein, fat in it's main graph display. Trio has not implemented this. A very simple PR to address this is possible. This is useful for anyone who references carb/fat/protein entries in Nightscout for diabetes management.
Describe the solution you'd like
A very simple PR to add "fatInput" and "proteinInput" alongside the existing "carbInput". Note that this is partially implemented, with fat and protein set to nil. This solution just finishes that half-baked implementation to bring it home!
Describe alternatives you've considered
Writing custom code, or not doing this at all. Any new code would be unnecessary and would add complexity. Making use of the existing implementation is very straight-forward and follows the same pattern used for carbs. Not doing this would be silly, as it provides value for anyone who enters fat and protein in Trio (great feature with fat/protein conversion functionality!).
Additional context
Technical Details
This implements existing code within Trio that simply set fat and protein to = nil. All we will be doing in the PR Needed here is passing along the already existing values for fat and protein, so that Trio sends them to Nightscout alongside Carbs.
User Impact
Any person who uses Trio with fat and protein entries, and who uses Nightscout to review entries will benefit from this.
The text was updated successfully, but these errors were encountered: