Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename smbIsAlwaysOff to smbIsScheduledOff (alpha) #120

Merged
merged 9 commits into from
May 1, 2024

Commits on Apr 17, 2024

  1. Rename smbIsAlwaysOff to smbIsScheduledOff

    Also rewords "Last Hour SMBs are Off" to "First Hour SMBs are Resumed" to hopefully be a little clearer, and hides "Schedule when SMBs are Off" switch when "Disable SMBs" is switched on instead of disabling it when "Disable SMBs" is switched off.
    MikePlante1 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0b68835 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Fix and refactor unChanged() for Profile Overrides

    Refactored by @polscm32 for readability.
    Logic changes by @MikePlante1 :
    + Removed checking `smbIsOff` from `defaultProfile`
    + Added checking for `smbIsScheduledOff` to `allSettingsDefault`
    + Removed checking `isf` and `cr` from `allSettingsDefault`
    
    Co-Authored-By: polscm32 <107251660+polscm32@users.noreply.github.com>
    MikePlante1 and polscm32 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e8183a3 View commit details
    Browse the repository at this point in the history
  2. Add icon and time range to profile label

    Displays time range in label when SMBs are scheduled off in profile override.
    For example, if the range is set from 22:00-6:00 it would display
    ⃠ 22-6
    MikePlante1 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0336592 View commit details
    Browse the repository at this point in the history
  3. Don't display a comma in override label...

    When `Disable SMBs` or `Schedule When SMBs are Off` is the only thing changed.
    
    Note, this commit does not fix that changes to SMB minutes are not displayed in the label.
    MikePlante1 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    daa2150 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. *"Always Disable SMBs"

    MikePlante1 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8bc49d3 View commit details
    Browse the repository at this point in the history
  2. Merge alpha into disable-smb-schedule

    Merge pull request #2 from nightscout/alpha
    MikePlante1 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5fc2766 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    7f4e482 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Update oref0 for #120 Rename smbIsAlwaysOff to smbIsScheduledOff

    Includes open-iaps-oref PR 20 and PR 17 (console error fix)
    
     Last commits:
    +5774155 Merge pull request 20 from MikePlante1/disable_smb_schedule
    +e3a8d73 Merge pull request 17 from MikePlante1/console_error_refactor
    +a29d9ce rename smbIsAlwaysOff to smbIsScheduledOff
    +d898eb1 fix threshold console.error
    
    Co-authored-by: Mike Plante <mikeplante1@gmail.com>
    bjornoleh and MikePlante1 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d317c53 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4 from bjornoleh/disable-smb-schedule

    Update oref0 for #120 Rename smbIsAlwaysOff to smbIsScheduledOff
    MikePlante1 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9f5446a View commit details
    Browse the repository at this point in the history