Update README.md: Create ConfigOverride.xcconfig by command line

[bjornoleh]

No description provided.

[marionbarker]

I recommend adding the BuildTrio.sh instructions below the line that says there is a script available.

Copy the code embedded here into the Trio README:

https://github.com/loopandlearn/lnl-scripts/tree/main?tab=readme-ov-file#scripts-for-the-trio-app

Code inspection OK of what you added looks good but I can’t test it right now.

[MikePlante1]

Did you want to add the build script that Marion mentioned? If you’d prefer that left for a different PR, then LGTM.

[bjornoleh]

We can fit that in here if someone has a chance to push it now, otherwise merge as is.

[MikePlante1]

We can fit that in here if someone has a chance to push it now, otherwise merge as is.

Thoughts on this?

[bjornoleh]

We can fit that in here if someone has a chance to push it now, otherwise merge as is.

Thoughts on this?

Looks great!

[marionbarker]

I reviewed the entire README file after the last commit/
Please add the missing links that are now known.

Look for TODO:

• There are 3 of them
• I know at least one of those is now known.

Tests:

• I tested the addition of the script and it worked.
• I tested the manual instructions and they work.
• Tests performed using a test phone running iOS 17.4.1 with Xcode 15.3

[MikePlante1]

I reviewed the entire README file after the last commit/ Please add the missing links that are now known.

Look for TODO:

• There are 3 of them
• I know at least one of those is now known.

I added a link for Docs (and links to FAX and Oref0), but should probably wait to add the website (diy-trio.org) and the Crowdin (until @t1dude says it's ready for contributions)

[marionbarker]

LGTM

[LiroyvH]

Note: when you list it like so (as it is in the current proposal):

git clone --branch=<branch> --recurse-submodules https://github.com/nightscout/Trio.git
cd Trio

Then if the default shell is still set to bash, copy/pasting it to Terminal will automatically execute the first command; which will fail because of the <branch>. This will thus result in an error such as:
"bash: branch: No such file or directory"

I'd suggest writing it as follows, so that when copy/pasting directly to Terminal the user will - regardless of which shell they're using - always have an opportunity to change the <branch> portion before execution (and it auto-terminates if the git command fails for whatever reason; preventing an error for cd on such an occasion):

git clone --branch=<branch> --recurse-submodules https://github.com/nightscout/Trio.git && cd Trio

[MikePlante1]

git clone --branch=<branch> --recurse-submodules https://github.com/nightscout/Trio.git && cd Trio

Thanks for the suggestion.

2-line in zsh: success
2-line in bash: fail
1-line in zsh: success
1-line in bash: success

I'll commit that now with you as the author

[becksen]

reviewed