Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App Name and Logos #19

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update App Name and Logos #19

merged 1 commit into from
Mar 22, 2024

Conversation

tmhastings
Copy link
Contributor

Change the displayed app name to "OiAPS"
Addition of new OiAPS app icon and watch icon. Set new OiAPS icons as primary.
New App Icon:
OiAPS App Icon

New Watch Icon:
OiAPS Watch Icon

@tmhastings tmhastings self-assigned this Mar 19, 2024
Copy link
Contributor

@MikePlante1 MikePlante1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I built it to a real (test) phone, iPhone SE(2nd gen) iOS 16.2, and it successfully changed the app's name and default icon, while retaining the ability to switch to the older icons still in the settings menu.

I do not have a Apple Watch available for testing, so did not test that.

IMG_0012

Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MikePlante1 MikePlante1 merged commit a81bba6 into nightscout:dev Mar 22, 2024
@MikePlante1 MikePlante1 mentioned this pull request Mar 22, 2024
@avouspierre
Copy link
Contributor

tested on dev but the logo of Watch App is not updated. @MikePlante1

@Sjoerd-Bo3
Copy link
Contributor

tested on dev but the logo of Watch App is not updated. @MikePlante1

I will chekc again, maybe there was some remnant of my dev branch or something.

@bjornoleh
Copy link
Contributor

tested on dev but the logo of Watch App is not updated. @MikePlante1

It could be that the code is ok. I have seen people mention having to uninstall the watch app sometimes to get the icon to update.

@avouspierre
Copy link
Contributor

I deleted the watch app and reinstall it but it is the iAPS logo.

@MikePlante1
Copy link
Contributor

@avouspierre I have an idea of what the problem might be. I’m turning off iAPS later today to test Mobi for a week or so, so I’ll be able to install on my watch to test it tonight and will submit the PR if it works.

@avouspierre
Copy link
Contributor

I restart my watch... and the logo is good ! probably a cache somewhere... well-done @MikePlante1

bjornoleh added a commit that referenced this pull request Apr 1, 2024
Changing the app display name from `OiAPS` (as introduced in #19) to `Open-iAPS`, after having discussed this in Discord.
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants