-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override refactor + override in charts + override in Watch #219
Commits on May 19, 2024
-
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for f1db386 - Browse repository at this point
Copy the full SHA f1db386View commit details -
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for 2db8ff9 - Browse repository at this point
Copy the full SHA 2db8ff9View commit details -
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for 2c6159f - Browse repository at this point
Copy the full SHA 2c6159fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae2e893 - Browse repository at this point
Copy the full SHA ae2e893View commit details -
Add override profil for apple watch
Add override options for apple watch inside the temp target menu. - allows to select a override preset (or a temp target) - allows to cancel a current override preset or specific override (idem for temp target) - add a color profil for override profil - Fix some minor code
Configuration menu - View commit details
-
Copy full SHA for 1dc21be - Browse repository at this point
Copy the full SHA 1dc21beView commit details
Commits on May 20, 2024
-
fix a concurrency issue about overrideObserver
use async to update overrideObserver.
Configuration menu - View commit details
-
Copy full SHA for 26ff1bb - Browse repository at this point
Copy the full SHA 26ff1bbView commit details
Commits on May 25, 2024
-
Remove duplicate "Remote control" toggle from preferences
Keep the one in Nightscout Config
Configuration menu - View commit details
-
Copy full SHA for 97fa79f - Browse repository at this point
Copy the full SHA 97fa79fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a21f15 - Browse repository at this point
Copy the full SHA 1a21f15View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd5e56f - Browse repository at this point
Copy the full SHA cd5e56fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 374d44f - Browse repository at this point
Copy the full SHA 374d44fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e065c - Browse repository at this point
Copy the full SHA a4e065cView commit details -
- One more click to reach the service, but - Added chevron in settings list (for consistency) - Added room for information/explainations of the setting in header/footer in the new view - First draft to build on (maybe: rephrase header/footer, add connection status in navigation view, other relevant info etc)
Configuration menu - View commit details
-
Copy full SHA for b67295c - Browse repository at this point
Copy the full SHA b67295cView commit details -
Change button text "Tidepool" -> "Connect to Tidepool"
- and remove uneccessary header
Configuration menu - View commit details
-
Copy full SHA for 4b682f3 - Browse repository at this point
Copy the full SHA 4b682f3View commit details -
Change all TidePool* entries in all files to Tidepool*
-and also tidePool* to tidepool*
Configuration menu - View commit details
-
Copy full SHA for cee2de7 - Browse repository at this point
Copy the full SHA cee2de7View commit details -
Adjustements after review @dnzxy
- Footer text in 2 elements - spelling error fix and Connect to Tidepool from ontapgesture text -> Action button with blue text for consistency
Configuration menu - View commit details
-
Copy full SHA for 3ccb7ab - Browse repository at this point
Copy the full SHA 3ccb7abView commit details -
Fix for sheet appearing and disappearing on first view
- Sheet needed to be moved outside Form (Swift curiosity)
Configuration menu - View commit details
-
Copy full SHA for ada0ea3 - Browse repository at this point
Copy the full SHA ada0ea3View commit details -
Add toggle to allow downloads from Nightscout
Treatments: Carbs and Temp Targets - and also announcements
Configuration menu - View commit details
-
Copy full SHA for 0fd6aa2 - Browse repository at this point
Copy the full SHA 0fd6aa2View commit details -
Reworked Nightscout Config View with subviews
- Imroved structure and UX workflow when configuring Nightscout settings - Added Connect, Upload, Fetch views with relevant settings per view - Import settings and backfill glucose buttons kept in rootview since they are more frequently used - Added footers for many sections to explain what the toggles actually do - Loacalizaation needed for new textstrings. Just updated that with small changes in already existing strings
Configuration menu - View commit details
-
Copy full SHA for 1b20a54 - Browse repository at this point
Copy the full SHA 1b20a54View commit details -
Adjustments to footer texts after review/feedback from @dnzxy
- Break up long strings in several text elements (enables re-use of some already existing translations) - Change button text "Connect" to "Connect to Nightscout" in NightscoutConnectView
Configuration menu - View commit details
-
Copy full SHA for 71edd1f - Browse repository at this point
Copy the full SHA 71edd1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a8eee4 - Browse repository at this point
Copy the full SHA 1a8eee4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca04fcd - Browse repository at this point
Copy the full SHA ca04fcdView commit details -
Display Pump Statut Highlight Message in home view
Display the eventual Pump Statut Highlight Message in home view if state is warning or critical. fix partially issue nightscout#207
Configuration menu - View commit details
-
Copy full SHA for ef4a3ce - Browse repository at this point
Copy the full SHA ef4a3ceView commit details -
Change statut to status variable and function
Configuration menu - View commit details
-
Copy full SHA for ca7b5a2 - Browse repository at this point
Copy the full SHA ca7b5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b137521 - Browse repository at this point
Copy the full SHA b137521View commit details -
Override refactoring and additional functionnalities
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Configuration menu - View commit details
-
Copy full SHA for f5c66dd - Browse repository at this point
Copy the full SHA f5c66ddView commit details -
Fix a issue with duplicate ID target
Fix a issue when you want to extend a current preset.
Configuration menu - View commit details
-
Copy full SHA for a4cd039 - Browse repository at this point
Copy the full SHA a4cd039View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0bb426 - Browse repository at this point
Copy the full SHA c0bb426View commit details
Commits on May 26, 2024
-
Reduce the call of coredata for override when a observer is executed Reduce the observer update
Configuration menu - View commit details
-
Copy full SHA for cf676a1 - Browse repository at this point
Copy the full SHA cf676a1View commit details