Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override refactor + override in charts + override in Watch #219

Closed
wants to merge 28 commits into from

Commits on May 19, 2024

  1. Override refactoring and additional functionnalities

    The PR includes a large refactoring of the swift part of override/profile functions :
    - Override is stored in override core data, including history
    - Override preset is stored in overridepreset core data
    - Add the display of the override in main graph
    - add the upload of override as a exercice in Nightscout - Fix nightscout#145
    - improve the management of indefinate override / stop of indefinate override
    - modify the code to respect the Ivan’s patterns of the app :
         - Use of swiftInject (dependency injection) with the use of protocol class in the code
         - Use of MVP principes, in particular not use of direct coredata in view class
         - Use of a proxy model class between coredata and the app to manage changes of core data
         - Use of the pattern of observe to refresh data/view/uploads
    
    - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests.
    - test for overrideStorage available
    
    This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
    
    TODO : Changes the shortcuts after merging with PR nightscout#144  and add watch for overrides.
    avouspierre committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f1db386 View commit details
    Browse the repository at this point in the history
  2. Override refactoring and additional functionnalities

    The PR includes a large refactoring of the swift part of override/profile functions :
    - Override is stored in override core data, including history
    - Override preset is stored in overridepreset core data
    - Add the display of the override in main graph
    - add the upload of override as a exercice in Nightscout - Fix nightscout#145
    - improve the management of indefinate override / stop of indefinate override
    - modify the code to respect the Ivan’s patterns of the app :
         - Use of swiftInject (dependency injection) with the use of protocol class in the code
         - Use of MVP principes, in particular not use of direct coredata in view class
         - Use of a proxy model class between coredata and the app to manage changes of core data
         - Use of the pattern of observe to refresh data/view/uploads
    
    - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests.
    - test for overrideStorage available
    
    This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
    
    TODO : Changes the shortcuts after merging with PR nightscout#144  and add watch for overrides.
    avouspierre committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2db8ff9 View commit details
    Browse the repository at this point in the history
  3. Override refactoring and additional functionnalities

    The PR includes a large refactoring of the swift part of override/profile functions :
    - Override is stored in override core data, including history
    - Override preset is stored in overridepreset core data
    - Add the display of the override in main graph
    - add the upload of override as a exercice in Nightscout - Fix nightscout#145
    - improve the management of indefinate override / stop of indefinate override
    - modify the code to respect the Ivan’s patterns of the app :
         - Use of swiftInject (dependency injection) with the use of protocol class in the code
         - Use of MVP principes, in particular not use of direct coredata in view class
         - Use of a proxy model class between coredata and the app to manage changes of core data
         - Use of the pattern of observe to refresh data/view/uploads
    
    - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests.
    - test for overrideStorage available
    
    This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
    
    TODO : Changes the shortcuts after merging with PR nightscout#144  and add watch for overrides.
    avouspierre committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2c6159f View commit details
    Browse the repository at this point in the history
  4. fix when preset has no id

    fix when preset has no id
    avouspierre committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ae2e893 View commit details
    Browse the repository at this point in the history
  5. Add override profil for apple watch

    Add override options for apple watch inside the temp target menu.
    
    - allows to select a override preset (or a temp target)
    - allows to cancel a current override preset or specific override (idem for temp target)
    - add a color profil for override profil
    - Fix some minor code
    avouspierre committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1dc21be View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. fix a concurrency issue about overrideObserver

    use async to update overrideObserver.
    avouspierre committed May 20, 2024
    Configuration menu
    Copy the full SHA
    26ff1bb View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Remove duplicate "Remote control" toggle from preferences

    Keep the one in Nightscout Config
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    97fa79f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a21f15 View commit details
    Browse the repository at this point in the history
  3. restore testing for submodules

    marionbarker authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    cd5e56f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    374d44f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a4e065c View commit details
    Browse the repository at this point in the history
  6. Add Tidepool navigation view

    - One more click to reach the service, but
    - Added chevron in settings list (for consistency)
    - Added room for information/explainations of the setting in header/footer in the new view
    - First draft to build on (maybe: rephrase header/footer, add connection status in navigation view, other relevant info etc)
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    b67295c View commit details
    Browse the repository at this point in the history
  7. Change button text "Tidepool" -> "Connect to Tidepool"

    - and remove uneccessary header
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    4b682f3 View commit details
    Browse the repository at this point in the history
  8. Change all TidePool* entries in all files to Tidepool*

    -and also tidePool* to tidepool*
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    cee2de7 View commit details
    Browse the repository at this point in the history
  9. Adjustements after review @dnzxy

    - Footer text in 2 elements
    - spelling error fix
     and Connect to Tidepool from ontapgesture text ->  Action button with blue text for consistency
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    3ccb7ab View commit details
    Browse the repository at this point in the history
  10. Fix for sheet appearing and disappearing on first view

    - Sheet needed to be moved outside Form (Swift curiosity)
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    ada0ea3 View commit details
    Browse the repository at this point in the history
  11. Add toggle to allow downloads from Nightscout

    Treatments: Carbs and Temp Targets - and also announcements
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    0fd6aa2 View commit details
    Browse the repository at this point in the history
  12. Reworked Nightscout Config View with subviews

    - Imroved structure and UX workflow when configuring Nightscout settings
    - Added Connect, Upload, Fetch views with relevant settings per view
    - Import settings and backfill glucose buttons kept in rootview since they are more frequently used
    - Added footers for many sections to explain what the toggles actually do
    - Loacalizaation needed for new textstrings. Just updated that with small changes in already existing strings
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    1b20a54 View commit details
    Browse the repository at this point in the history
  13. Adjustments to footer texts after review/feedback from @dnzxy

    - Break up long strings in several text elements (enables re-use of some already existing translations)
    - Change button text "Connect" to "Connect to Nightscout" in NightscoutConnectView
    dsnallfot authored and avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    71edd1f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1a8eee4 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ca04fcd View commit details
    Browse the repository at this point in the history
  16. Display Pump Statut Highlight Message in home view

    Display the eventual Pump Statut Highlight Message in home view if state is warning or critical.
    
    fix partially issue nightscout#207
    avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    ef4a3ce View commit details
    Browse the repository at this point in the history
  17. Change statut to status

    Change statut to status variable and function
    avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    ca7b5a2 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    b137521 View commit details
    Browse the repository at this point in the history
  19. Override refactoring and additional functionnalities

    The PR includes a large refactoring of the swift part of override/profile functions :
    - Override is stored in override core data, including history
    - Override preset is stored in overridepreset core data
    - Add the display of the override in main graph
    - add the upload of override as a exercice in Nightscout - Fix nightscout#145
    - improve the management of indefinate override / stop of indefinate override
    - modify the code to respect the Ivan’s patterns of the app :
         - Use of swiftInject (dependency injection) with the use of protocol class in the code
         - Use of MVP principes, in particular not use of direct coredata in view class
         - Use of a proxy model class between coredata and the app to manage changes of core data
         - Use of the pattern of observe to refresh data/view/uploads
    
    - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests.
    - test for overrideStorage available
    
    This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
    
    TODO : Changes the shortcuts after merging with PR nightscout#144  and add watch for overrides.
    avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    f5c66dd View commit details
    Browse the repository at this point in the history
  20. Fix a issue with duplicate ID target

    Fix a issue when you want to extend a current preset.
    avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a4cd039 View commit details
    Browse the repository at this point in the history
  21. add edit profiles

    Add edit based on PR nightscout#235
    avouspierre committed May 25, 2024
    Configuration menu
    Copy the full SHA
    c0bb426 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Update Observer for override

    Reduce the call of coredata for override when a observer is executed
    Reduce the observer update
    avouspierre committed May 26, 2024
    Configuration menu
    Copy the full SHA
    cf676a1 View commit details
    Browse the repository at this point in the history