Backport HealthKit fix to earlier version #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally implemented this fix in a slightly newer version, so this is a backport. This meant that I had to make a few changes in NS and some other places to make the API compatible. The actual fix itself is what's in
HealthKitManager.swift
, everything else is to conform to that version of the HKM API wherever it's being called.More specifically, the HealthKitManager fix are the following parts:
syncID
->syncID.id
: https://github.com/nightscout/Open-iAPS/compare/apple-health-fix?expand=1#diff-ad150566aaf780d912eaea022c0e727588f1d24ce1c8ee38997162e5f19c040bR256.sink
it was no longer valid.