Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset profile override name textbox after saving #230

Merged
merged 1 commit into from
May 23, 2024
Merged

Reset profile override name textbox after saving #230

merged 1 commit into from
May 23, 2024

Conversation

MikePlante1
Copy link
Contributor

Proposed solution for #229

Tested in a simulator and on a spare iPhone.

@MikePlante1 MikePlante1 mentioned this pull request May 22, 2024
Closed
bjornoleh
bjornoleh approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. Tested by building to a phone.

dnzxy
dnzxy approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@dnzxy
Copy link
Contributor

dnzxy commented May 23, 2024

Merging with 2 approvals. Solves #229 .

@dnzxy dnzxy merged commit cfaf4a0 into nightscout:dev May 23, 2024
1 check passed
@MikePlante1 MikePlante1 mentioned this pull request May 27, 2024
Merged
@MikePlante1 MikePlante1 mentioned this pull request Jun 16, 2024
Closed
4 tasks
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Aug 1, 2024
@Jon-b-m
Dutch (nightscout#230)
8056321
@MikePlante1 MikePlante1 deleted the profile_name_reset branch August 18, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnzxy dnzxy dnzxy approved these changes

@bjornoleh bjornoleh bjornoleh approved these changes

@AndreasStokholm AndreasStokholm Awaiting requested review from AndreasStokholm AndreasStokholm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikePlante1 @dnzxy @bjornoleh