Minimum Safety Threshold update
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes default of minimum safety threshold to `60` from `65` to match standard oref. - Changes name of setting from `Threshold Setting (mg/dL)` to `Minimum Safety Threshold (mg/dL)`. - Updates tooltip to improve clarity.
JeremyStorring
previously approved these changes
Jun 1, 2024
|
LGTM! |
|
Minor suggestion for improvement (?), as it may not be clear what the “If you use mmol” part actually means: Must be set between 60-120 mg/dL. If you use mmol/L, multiply by 18 -> Must be set between 60-120 mg/dL. To convert from mmol/L to mg/dL, please multiply by 18 |
"If you use mmol/L," -> "To convert from mmol/L," Co-Authored-By: bjornoleh <63544115+bjornoleh@users.noreply.github.com>
MikePlante1
force-pushed
the
threshold_typo
branch
from
10dcb23
to
fb97b13
Compare
Thanks. Just pushed that update. |
bjornoleh
approved these changes
Jun 2, 2024
|
Merging with two approving reviews |
Merged
mountrcg
added a commit
to mountrcg/Trio
that referenced
this pull request
Jun 15, 2024
`Minimum Safety Threshold` update
4 tasks
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
60from65to match standard oref.20 + ½ TargetGlucose. Since 80 mg/dL is the lowest oref will use as a target, 60 mg/dL is the lowest oref will set the safety threshold to.Threshold Setting (mg/dL)toMinimum Safety Threshold (mg/dL).