add observer on pump deactivated to initialize pump status #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornoleh
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Tested successfully in Xcode simulator (iPhone 15):
Before fix: Added Dash and removed the pump, the "No pod" warning appears also after removal
After fix: Added Dash and removed the pump, "Add pump" is displayed instead.
I did not review the code changes thoroughly, although I get the gist of it.
dnzxy
approved these changes
Jun 8, 2024
|
Merging with two approvals Great job, @kskandis! |
|
Testing after merge for completeness. Status
Configuration
Testing
|
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Jun 15, 2024
…ump-deactivated add observer on pump deactivated to initialize pump status
4 tasks
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
… recycled (nightscout#285) * Update DexcomSourceG5.swift Generate unique _id value to prevent Mongo collisions in Nightscout * Update DexcomSourceG6.swift Generate unique _id value to prevent Mongo collisions in Nightscout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Issue Home View shows "No Pod" or "Signal Loss" despite insulin delivery system removal
#283
Tested Omnipod and Medtronics on Simulator