Resolve issue #289: implement NS-provided display of fat/protein #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aug0211
commented
Jun 9, 2024
aug0211
commented
- Resolves Make use of Nightscout's provided display of Carbs + Protein + Fat in graph for meal entries #289
- Implements Nightscout's provided graph display for fat and protein in meal entries
- Trio had partially implemented this but did not pass fat and protein values to Nightscout (it dropped them but carried carbs)
- This PR follows the identical pattern used for carbs and carries fat and protein values along for NS to display
…otein in graph - Resolves (Trio issue nightscout#289)[nightscout#289] - Implements Nightscout's provided graph display for fat and protein in meal entries - Trio had partially implemented this but did not pass fat and protein values to Nightscout (it dropped them but carried carbs) - This PR follows the identical pattern used for carbs and carries fat and protein values along for NS to display
aug0211
requested review from
avouspierre,
MikePlante1,
dnzxy,
bjornoleh and
dsnallfot
MikePlante1
approved these changes
Jun 9, 2024
dnzxy
approved these changes
Jun 9, 2024
|
Looks good! Merging with two approvals. |
dsnallfot
reviewed
Jun 9, 2024
This was referenced Jun 10, 2024
Merged
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
* update enact bolus button description when amount exceeds maxBolus and fix insulin unit description * reimplement continue without bolus button, delete unnecessary code in BolusStateModel * refactor code and let add insulin button be disabled if maxBolus is exceeded * remove unused variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.