Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include high and low values in TIR in Statistics #298

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

MikePlante1
Copy link
Contributor

This changes the statistics to include the high and low values in the normal range instead of the high and low ranges. This would match the colors of the glucose dots on the Statistics screen.

For this example in a simulator, I kept high/low to the default 70/180 and manually entered these values:

glucose values
Before this PR (standing) Before this PR (laying)
old standing old laying
After this PR (standing) After this PR (laying)
new standing new laying

@bjornoleh bjornoleh self-requested a review June 11, 2024 18:47
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review:

The code changes looks good and are limited to the required changes for the scope of this PR.

Test build to iPhone 13 mini:

Builds: ✅
TIR definition ok both for standing and laying chart ✅
mmol/L tested ok: ✅

  • 3,8 below range
  • 3,9 within range
  • 10,0 within range
  • 10,1 above range

No uncommitted auto linting: ✅

Copy link
Contributor

@AndreasStokholm AndreasStokholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in sim and on a test phone with a Pi sim. Works and shows values as expected in both mg/dL and mmol/L.

Also, big plus for removing the ligatures 👏

@bjornoleh
Copy link
Contributor

Merging with two 👍

@bjornoleh bjornoleh merged commit 7a6ddf3 into nightscout:alpha Jun 13, 2024
1 check passed
@MikePlante1 MikePlante1 deleted the stats branch June 13, 2024 20:09
@MikePlante1 MikePlante1 restored the stats branch June 13, 2024 20:09
@MikePlante1 MikePlante1 mentioned this pull request Jun 25, 2024
@MikePlante1 MikePlante1 deleted the stats branch August 14, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants