Live Activities #35
Live Activities #35
Conversation
adding in liveactivity identifier forcing xcode 15.0.1 for creating certs
* fix mmol live activity, live activity off by default, re-create live activity always after it ended, better readability on lock screen * typo * lock screen cleanup * fix padding, fix misaligned trailing dynamic island view * camel case * prevent unwanted hiding of live activity, update dynamic island padding * also hide change label on stale live activity data * update colors
fix incorrect timelabels in main chart fix xGridLines that disappeared after last dev merge
improve readability for lockscreen widget in light mode
Use same calculator on Watch as on iPhone app.
This reverts changes not related to coreData for LiveActivities from commit a1c1160.
* conditionally show glucose graph in different colors dependent of high and low glucose settings * To Do: add setting for showing graph in lockscreen and/or just a minimalistic view
- Run calculation of total insulin on scope only on change of picker panel, on appearance of the app and on change of boluses * to do: fix tins not updating on Pump History change - Dynamic Island updates * add cob to lockscreen widget * add iob to lockscreen widget and adjust padding/spacing * to do: fix delay of updating cob and iob - Change gradient of custom background color
This reverts changes not related to LiveActivities from commit 98fcad4.
…ations menu" This reverts commit b06ae0a.
fastlane/Fastfile
Outdated
| @@ -189,6 +196,10 @@ platform :ios do | |||
| configure_bundle_id("FreeAPSWatch", "#{BUNDLE_ID}.watchkitapp", [ | |||
| Spaceship::ConnectAPI::BundleIdCapability::Type::APP_GROUPS | |||
| ]) | |||
|
|
|||
| configure_bundle_id("LiveActivityExtension", "ru.artpancreas.#{TEAMID}.FreeAPS.LiveActivity", [ | |||
There was a problem hiding this comment.
@MikePlante1 Another ru.artpancreas here.
fastlane/Fastfile
Outdated
| @@ -124,6 +125,12 @@ platform :ios do | |||
| code_sign_identity: "iPhone Distribution", | |||
| targets: ["FreeAPSWatch"] | |||
| ) | |||
| update_code_signing_settings( | |||
| path: "#{GITHUB_WORKSPACE}/FreeAPS.xcodeproj", | |||
| profile_name: mapping["ru.artpancreas.#{TEAMID}.FreeAPS.LiveActivity"], | |||
There was a problem hiding this comment.
@MikePlante1 Please note the relict ru.artpancreas here
There was a problem hiding this comment.
Thanks. I’ll get that fixed today.
@Sjoerd-Bo3 , I moved the updated label up a bit to make the padding more consistent. Is this better? |
Yes, but in my view the chart needs to be a little down and to the right? It's not centered vertically and a little bit cramped on the left top. It needs a bit of safespace. If you know what I mean. Maybe tomorrow I can look at it. |
bjornoleh
force-pushed
the
liveActivities
branch
from
0af07a7
to
0a161a1
Compare
Fix for the LiveActivity identifier in match()
"#{BUNDLE_ID}.LiveActivity"
I would like to propose this (don't mind the bobble, that is just for me 🤣): Done like: Also on your Screenshot the Updated tag is too much on the edge because of the "AM", but don't have the solution for that. Maybe a safezone in the whole widget would fix it. |
|
I added your padding and nudged Updated over a smidge. Thoughts, @Sjoerd-Bo3 ? 
|
|
Guys, this looks absolutely off and skewed. There are guidelines for how live activity cards should be designed and certain safe spaces that should be kept. Mike, your initial design looked great and had those. The recent changes don’t. Refer to this example image by Apple: In terms of paddings and margins: the initial design was okay and "correct". The chart as a whole design element (that includes axis marks, axis ticks, etc) had an even spacing all around. What was highlighted in a screenshot above as looking "off" was just the canvas space, not the actual chart-as-a-whole. Let’s please not get stuck on such details now, when a wider redesign of the app definitely being up for grabs once 1.0.0 has dropped. *Edit to fix typos. |
|
From the initially proposed design there’s one element that is slightly off: the updated string. That would need to move up a little to make the LA card confer to Apple‘s guidelines. |
You can't say that the chart is right in this one: I can agree on getting even bigger margins in there but this picture just doesn't look like it should be, it lacks a safe space. I strongly agree on the updated sign, Can't we change the wording to "Last:" or something? Because with the "AM" it is just too long. And indeed in needs to go up, and also maybe the whole right part a little to the left to give it a little more room on the right. Sorry but from a UI perspective the chart carries weight. It should clear the bend at least: Source: https://developer.apple.com/design/human-interface-guidelines/live-activities |
|
The 300 tick on the y-axis and the updated-string are the only 2 elements that are "off", the rest is fine. Again, you are not looking at the chart as a whole element there. Don’t mind my bad drawing skills on my phone please, but the red rectangle is the chart element and if you ignore the bad drawing a bit you‘ll realize the margin is even all around, i.e. what I‘ve been trying to say. Edit to add: we basically need to put elements within this "inner" frame / safe space. |
|
Yeah okay, still don't agree on the top of the graph though. |
|
Looking at the same sources as you are; that’s why I brought it up. The chart is a combination of text and a non-rounded shape content, so in a way both those rules apply. The top of the graph (the axis mark 300 for the y-axis) is off, I agree with you 🤷🏻♂️ |
But to fix that 300, we need to put a 13 pt margin right? it shouldn't be outside that frame. Sorry if I'm coming off annoying, but I'm a design snob and the area on the bottom compared to the top of the chart feels really off. Not like an apple thing. |
|
Side note: It would be nice in the future to expand the dynamic island when an alert comes in or something. |
|
Yup, and I‘m a person that worked as an actual designer for 5yrs, so we clash. It’s all good - we‘re discussing, not being annoying 😊 I‘d need to get a display ruler here and really check the exact distances, but this should be okay. The axis ticks and marks are just a bit off and I think that’s why it all looks a bit weird to some. One could maybe try rotating the numbers for the axis marks on the y-axis by 90 degree, so that they take the same height/width (depending on interpretation) as the marks on the x-axis, which could make it look more even and also let margins be perceived as more even. It might also implicitly fix the top y-axis mark from being off. I‘m not sure if that can easily be done with Swift Charts; other chart frameworks I‘ve worked with (D3 for example) can do that. The current implementation of the live activity and dynamic island feature is a V1.0 by a user named nas10 for iAPS who chose not to contribute anymore due to the drama happening over there. I‘m sure he might actually resurface once Oi gets released. |
|
You can rotate the marks as you want to, but I really don't think thats necessary here 😅 |
Thanks for that info, so that’s doable, nice. It was just an idea to make the chart as an element more evenly sized all around to make it easier to evenly space it within the card. |
…trio Don't use default calendar if one is already set
This pull request is a collection of commits involving Live Activity, mostly from @10nas and @polscm32 .
Live Activities requires iOS 16.2 to work, but this PR does not change the minimum iOS requirement to build and run Oi.
This adds a toggle in
⚙️>NotificationsforShow Live Activityand a picker forLock screen widgetwith optionsSimpleandDetailed.When
Show Live Activityis toggled on, glucose data will be added to the Lock Screen as a Live Activity widget and to the Dynamic Island if the phone supports Dynamic Island (iPhone 14 Pro, 14 Pro Max, and all iPhone 15 variants). Live activities will stay refreshed and up-to-date on their own, but only if Oi is running in the background and has been opened in the past 8 hours.If both slots are open in the Dynamic Island it will show current glucose and trend arrow on the left and delta on the right:
If only one slot is open in the Dynamic Island, it will only show current glucose and trend arrow, and squeeze it a bit so it fits in the smaller space:
Long pressing the Dynamic Island will expand it. Expanding when the default
Simpleis chosen in settings:Expanded Dynamic Island when
Detailedis chosen in settings:Statistics and Home Viewmenu. High = Orange, In-Range = Green, Low = Red. High is set to 140 for this screenshot.Lock screen widget with the default
Simplechosen in settings:Lock screen widget with
Detailedchosen in settings:Statistics and Home Viewmenu. High = Orange, In-Range = Green, Low = Red. High is set to 180 for this screenshot.If the last glucose value is over 5 minutes old, a red strikethrough will be added to indicate it being stale: