Prevent crash when holding backspace #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePlante1
requested review from
dnzxy,
bjornoleh,
aug0211,
AndreasStokholm,
Sjoerd-Bo3 and
t1dude
as code owners
MikePlante1
force-pushed
the
deleting_meal_note_fix
branch
from
6e3a120
to
82b818d
Compare
MikePlante1
changed the title
|
|
marionbarker
previously approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Summary
LGTM to fix the crash
Code Review
- code changes looks appropriate
- Can someone check localization?
- I tried different languages and did not see the decimal/thousands place delimiters I expected
- If confirmed, that should be a separate issue.
Test Details
Confirm problem
- build with dev, 8303f0a
- confirm 1 - crashed the app with backspace in Notes field
- confirm 2 - entered in carbs field - see the bug
Confirm fix
- apply patch from PR 352
- confirm fix 1 - able to backspace in notes field, app does not crash
- confirm fix 2 - entered
126555in carb field, displays 126,555 (with > max warning symbol)- delete one character at a time
- 12,655
- 1,265
- 126
- 12 (no longer > max carbs, symbol gone)
- delete one character at a time
- confirm maxLength works
- confirm clear works
- confirm proper thousands' place behavior in temp target, bolus
You have to change the Region of the phone, not the Language. Each of the following produces a different grouping separator: |
MikePlante1
force-pushed
the
deleting_meal_note_fix
branch
from
82b818d
to
061f4e9
Compare
|
I removed the grouping separator fix from this PR, as a similar solution has been added to #362 |
MikePlante1
changed the title
dnzxy
approved these changes
Jul 26, 2024
marionbarker
approved these changes
Jul 26, 2024
Merged
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Jul 29, 2024
…_fix Prevent crash when holding backspace
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Aug 1, 2024
* Update Bolus Cancel Button * Refactor --------- Co-authored-by: Jon Mårtensson <jon.m@live.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, entering text into
Notewhile entering a meal and then holding the backspace button would crash the app. This PR prevents that crash.