Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix calibration error in first start #94

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

avouspierre
Copy link
Contributor

fix #92 (hope)

@bjornoleh
Copy link
Contributor

Did you find a good way to reproduce the bug in the first place? I am unsure if my initial observations of cause and effect were accurate. If we know how to reproduce accurately, I can test again before and after this fix.

@avouspierre
Copy link
Contributor Author

Not sure but I succeeded to reproduce once...

@bjornoleh
Copy link
Contributor

I can not reproduce this any more without your fix... But your changes look reasonable, and I suppose it will be best to merge this into alpha now, and if no more crash reports, we suppose this was effective?

I did build with the change of this PR, and it caused no immediate issues.

I will merge this now so that the change becomes available (it is currently in your private branch only).

Please remember to make a separate PR to dev after some time of testing in alpha (after submodules are brought into dev).

@bjornoleh bjornoleh merged commit 23e711a into nightscout:alpha Apr 13, 2024
@MikePlante1 MikePlante1 mentioned this pull request Apr 16, 2024
@MikePlante1 MikePlante1 mentioned this pull request May 3, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Aug 1, 2024
…cout#9 & nightscout#18 and MinimedKit PR nightscout#6 (#438)

+ Extend low reservoir notification range
+ Prevent negative duration doses, which can happen if the phone clock is changed
+ Fixes Loop crash when changing time back and cancelling bolus, Loop Issue #2057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants