Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unhandled promise rejections for hidden frames #1762

Conversation

earshinov
Copy link
Contributor

Fixes the problem outlined in #1502 (comment)

Test plan (required) - TODO

Demonstrate how the issue/feature can be replicated. For most cases, simply adding an appropriate html/css template into the reftests should be sufficient. Please see other tests there for reference.

@niklasvh niklasvh merged commit 5cbe5db into niklasvh:master Apr 7, 2019
@earshinov earshinov deleted the prevent-unhandled-promise-rejections-for-hidden-frames branch November 23, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants