Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] now enables NIM_COMPILE_TO_CPP=true to run without allow_failures #10315

Merged
merged 3 commits into from
Jan 17, 2019

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jan 15, 2019

@timotheecour timotheecour requested a review from Araq January 15, 2019 12:51
@timotheecour timotheecour force-pushed the pr_enable_cpp_in_ci branch 2 times, most recently from b89c254 to 3a29fb6 Compare January 16, 2019 05:54
lib/system.nim Outdated Show resolved Hide resolved
@Araq
Copy link
Member

Araq commented Jan 16, 2019

I'm taking over, stay tuned.

@Araq Araq closed this Jan 16, 2019
@timotheecour
Copy link
Member Author

rsiseId gives error when building from csources, as i noted above, with cpp mode

@timotheecour
Copy link
Member Author

superseded by:

@timotheecour timotheecour reopened this Jan 16, 2019
@timotheecour
Copy link
Member Author

let me try something, please keep open for now

@timotheecour
Copy link
Member Author

timotheecour commented Jan 17, 2019

@Araq PTAL

  • I fixed that typo above(raise_id vs raiseId)
  • the latest fix I'm doing in this PR is better than 2039dad because it requires 1 fewer iteration of building nim, which is critical for saving on CI time (as well as on user's machines); it'll also automatically become a noop once csources get updated (without having to change anything)
  • also fixed another blocker for CPP
  • most importantly, NIM_COMPILE_TO_CPP=true is green for the 1st time!

@Araq Araq merged commit 42bac52 into nim-lang:devel Jan 17, 2019
@timotheecour timotheecour deleted the pr_enable_cpp_in_ci branch January 17, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants