-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] now enables NIM_COMPILE_TO_CPP=true
to run without allow_failures
#10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_enable_cpp_in_ci
branch
2 times, most recently
from
January 16, 2019 05:54
b89c254
to
3a29fb6
Compare
Araq
reviewed
Jan 16, 2019
I'm taking over, stay tuned. |
rsiseId gives error when building from csources, as i noted above, with cpp mode |
superseded by:
|
let me try something, please keep open for now |
timotheecour
force-pushed
the
pr_enable_cpp_in_ci
branch
from
January 16, 2019 22:20
3a29fb6
to
a311ec8
Compare
timotheecour
force-pushed
the
pr_enable_cpp_in_ci
branch
from
January 16, 2019 23:30
a311ec8
to
3373a16
Compare
timotheecour
force-pushed
the
pr_enable_cpp_in_ci
branch
from
January 17, 2019 01:26
3373a16
to
34458b1
Compare
@Araq PTAL
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CI] now enables
NIM_COMPILE_TO_CPP=true
to run without allow_failuresadds workaround for
nim cpp -r tests/exception/t9657
hangs #10343fixes bug caused by
csources
being built assumingraise_id
even though stdlib was updated in meantime to useraiseId
; this workaround can be removed after the next release of csources (but nothing will break if it's not removed)requires these other PR's the be merged first: EDIT: DONE!