cbuilder: second half of cgen #24432
Merged
+485
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
Araq
pushed a commit
that referenced
this pull request
Nov 15, 2024
fixes #24434 In #24432 ```nim let ex = "NIM_EXTERNC N_NIMCALL(void, nimLoadProcs$1)(void) {$2}$N$N" % [(i.ord - '0'.ord).rope, extract(el)] ``` ```nim procs.addDeclWithVisibility(ExternC): procs.addProcHeader(ccNimCall, "nimLoadProcs" & $(i.ord - '0'.ord), "void", cProcParams()) ``` extern "C" makes a function-name in C++ have C linkage; it should be effaced with C compiler
Araq
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #24423, needed more refactoring than I expected, sorry for ugly diff.
With this pretty much all of the raw C code generating parts of the codegen are abstracted into the cbuilder API (to my knowledge at least). The current design of NIFC does not implement everything the codegen generates, such things have mostly not been adapted, they are the following along with how I'm guessing they could be implemented:
codegenDeclpragma: Could be passed as a pragma to NIFCnimln_(123): Just inline them when generating NIFC#line: Maybe as NIFC directives or line infos?#ifndefwhen generating headers but NIFC shouldn't need italignof/offsetof: Is incbuilderbut not implemented in NIFC, should be easy Edit: Done nifc: add alignof & offsetof, make sizeof only take type nif#120For now we can disable C++ and the
codegenDeclpragma when generating NIFC but since cbuilder is mostly designed to generate NIFC as a flag when booting the compiler, this hinders the ability to run the CI against NIFC. Maybe we could also make cbuilder able to generate both C and NIFC at runtime, this would be a large refactor but wouldn't be too difficult.Other missing abstractions before being able to generate NIFC are:
int,void*,NI,NIM_NULLare currently still constant string literals,NU8,NU16etc are also sometimes generated like"NU" & $bits..cto imported symbols and properly mangling generated ones. Not sure how difficult this is going to be.