Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compiler and use nimscript with nim e instead #635
Remove compiler and use nimscript with nim e instead #635
Changes from 27 commits
93ba4a0
de18319
7adfd7b
e9a8850
2fc3106
cf7263d
3d7227c
220ebae
b9ef88b
ab38b81
0ed53d6
cbb3af3
7d0a40a
51d03b3
1e95fd4
deecd90
b05d948
8c2e65e
74201bc
85f3865
2942f11
5cf0240
b22fe37
24131de
d49916e
a031fff
64e5489
c278bd6
915d6b2
ae3ef9f
640ce3f
e86a376
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this? In fact, this will be wrong for
BRANCH=devel
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing worth caching in ~/.nimble. Also, caching only stable since the binary won't change. Devel shouldn't be cached so that we always test with latest. Otherwise we are testing with an old devel after first cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is.
The
.nimble/bin
is added to the PATH below, if this directory doesn't get cached then failures will happen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@genotrance as far as I'm concerned you need to revert this because it will break things, please do so (or explain why it must be this way).