From 1ae9048535287ef2c802da245f340a372ea8ee70 Mon Sep 17 00:00:00 2001 From: Arnaud MOURA Date: Tue, 9 Jun 2020 12:50:45 +0000 Subject: [PATCH 1/3] Add warning message when cloning the HEAD. --- src/nimblepkg/download.nim | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/nimblepkg/download.nim b/src/nimblepkg/download.nim index 3bbfa252..50ada421 100644 --- a/src/nimblepkg/download.nim +++ b/src/nimblepkg/download.nim @@ -205,6 +205,8 @@ proc doDownload(url: string, downloadDir: string, verRange: VersionRange, onlyTip = not options.forceFullClone) else: # If no commits have been tagged on the repo we just clone HEAD. + display("Warning:", "No corresponding tag found with required version. We grab HEAD.", Warning, + priority = HighPriority) doClone(downMethod, url, downloadDir) # Grab HEAD. of DownloadMethod.hg: doClone(downMethod, url, downloadDir, onlyTip = not options.forceFullClone) @@ -216,6 +218,9 @@ proc doDownload(url: string, downloadDir: string, verRange: VersionRange, display("Switching", "to latest tagged version: " & latest.tag, priority = MediumPriority) doCheckout(downMethod, downloadDir, latest.tag) + else: + display("Warning:", "No corresponding tag found with required version.", Warning, + priority = HighPriority) proc downloadPkg*(url: string, verRange: VersionRange, downMethod: DownloadMethod, From 71ea55ceae2e5c5e4dd57976331d386ed5b6dec0 Mon Sep 17 00:00:00 2001 From: Arnaud Moura Date: Sat, 26 Jun 2021 22:58:45 +0200 Subject: [PATCH 2/3] Update src/nimblepkg/download.nim Co-authored-by: Dominik Picheta --- src/nimblepkg/download.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nimblepkg/download.nim b/src/nimblepkg/download.nim index 50ada421..a13d11cc 100644 --- a/src/nimblepkg/download.nim +++ b/src/nimblepkg/download.nim @@ -205,7 +205,7 @@ proc doDownload(url: string, downloadDir: string, verRange: VersionRange, onlyTip = not options.forceFullClone) else: # If no commits have been tagged on the repo we just clone HEAD. - display("Warning:", "No corresponding tag found with required version. We grab HEAD.", Warning, + display("Warning:", "The package has no tagged releases, downloading HEAD instead.", Warning, priority = HighPriority) doClone(downMethod, url, downloadDir) # Grab HEAD. of DownloadMethod.hg: From f4ae63033f34e92a2407c90e1f3e6805f06d834a Mon Sep 17 00:00:00 2001 From: Dominik Picheta Date: Sun, 27 Jun 2021 13:51:31 +0100 Subject: [PATCH 3/3] Update download.nim --- src/nimblepkg/download.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nimblepkg/download.nim b/src/nimblepkg/download.nim index a13d11cc..b0985748 100644 --- a/src/nimblepkg/download.nim +++ b/src/nimblepkg/download.nim @@ -219,7 +219,7 @@ proc doDownload(url: string, downloadDir: string, verRange: VersionRange, priority = MediumPriority) doCheckout(downMethod, downloadDir, latest.tag) else: - display("Warning:", "No corresponding tag found with required version.", Warning, + display("Warning:", "The package has no tagged releases, downloading HEAD instead.", Warning, priority = HighPriority) proc downloadPkg*(url: string, verRange: VersionRange,