From b23565e13bea310bca6a14e345bbba92124bea44 Mon Sep 17 00:00:00 2001 From: Cole Snodgrass Date: Mon, 24 Oct 2022 09:37:02 -0700 Subject: [PATCH] remove useless json_size metric (#18247) --- .../airbyte/workers/internal/DefaultAirbyteStreamFactory.java | 1 - .../main/java/io/airbyte/metrics/lib/OssMetricsRegistry.java | 4 ---- 2 files changed, 5 deletions(-) diff --git a/airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/DefaultAirbyteStreamFactory.java b/airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/DefaultAirbyteStreamFactory.java index 8e002e39c21a..c8bd56efa0ab 100644 --- a/airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/DefaultAirbyteStreamFactory.java +++ b/airbyte-commons-worker/src/main/java/io/airbyte/workers/internal/DefaultAirbyteStreamFactory.java @@ -59,7 +59,6 @@ public Stream create(final BufferedReader bufferedReader) { .lines() .peek(str -> metricClient.distribution(OssMetricsRegistry.JSON_STRING_LENGTH, str.length())) .flatMap(this::parseJson) - .peek(json -> metricClient.distribution(OssMetricsRegistry.JSON_SIZE, json.size())) .filter(this::validate) .flatMap(this::toAirbyteMessage) .filter(this::filterLog); diff --git a/airbyte-metrics/metrics-lib/src/main/java/io/airbyte/metrics/lib/OssMetricsRegistry.java b/airbyte-metrics/metrics-lib/src/main/java/io/airbyte/metrics/lib/OssMetricsRegistry.java index 3c830e2a85f1..6962b7c56c01 100644 --- a/airbyte-metrics/metrics-lib/src/main/java/io/airbyte/metrics/lib/OssMetricsRegistry.java +++ b/airbyte-metrics/metrics-lib/src/main/java/io/airbyte/metrics/lib/OssMetricsRegistry.java @@ -71,10 +71,6 @@ public enum OssMetricsRegistry implements MetricsRegistry { MetricEmittingApps.WORKER, "json_string_length", "string length of a raw json string"), - JSON_SIZE( - MetricEmittingApps.WORKER, - "json_size", - "size of the json object"), KUBE_POD_PROCESS_CREATE_TIME_MILLISECS( MetricEmittingApps.WORKER, "kube_pod_process_create_time_millisecs",