lots of code, mostly basic testing setup #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with phantomcss
|
@alonisser did u check on chrome? it works well for me on FF but seems to not show the map on Chrome (we had various issues with the map div not being %100 on some browsers) |
|
@niryariv This version doesn't work on chrome? Actually I checked only on chrome and the automated tests are also webkit based (as chrome still is currently). strange, what chrome are you running? does the console show something? |
|
@niryariv does the console show some problem? from my tests the map won't load if jquery doesn't load (and I changed the jquery reference to use a minified version) or if app.js has some error stoping it from working |
niryariv
added a commit
that referenced
this pull request
Sep 30, 2013
lots of code, mostly basic testing setup
florpor
pushed a commit
to florpor/opentaba-client
that referenced
this pull request
Sep 10, 2014
lots of code, mostly basic testing setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Travic -ci support . close #22 . notice that you should change the
build passingto your fork in the readme.close #20
close #19
close #18 (just jQuery, leaflet was minified)
working on #15. still lots of work here
@niryariv about
index.html - please don't merge it automatically into gh-pages before you look at it. I'm not sure about the social icons look.Notice some setup needed for testing to work, check testing.md