-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jujutsu: update module to respect XDG config placement #5207
Conversation
5cd33c9
to
754491b
Compare
754491b
to
d768262
Compare
Thanks! Merged to master now 🙂 |
This breaks the configuration on macOS since Jujutsu does not currently support For now, I'm adding the following to my configuration: home.sessionVariables = lib.mkIf (pkgs.stdenv.hostPlatform.isDarwin) {
JJ_CONFIG = "${config.xdg.configHome}/jj/config.toml";
}; I'm not sure what the recommended solution is here. |
It's possible to branch on Follow-up PR : #5416 |
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Follow up to #5207, fixing jujutsu module on darwin targets.
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Follow up to nix-community#5207, fixing jujutsu module on darwin targets.
Description
Use the new supported XDG config place instead of home directory to make it cleaner
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
@shikanime