Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: install kio when qt.platformTheme = "kde" #6181

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

alyraffauf
Copy link
Contributor

Description

Following discussions at NixOS/nixpkgs#362949, this PR fixes file dialogs when KDE is not installed but qt.platformTheme = "kde" (common for theming purposes). Without it, file dialogs fail to show files and folders. Only an issue when KDE is not installed, because KDE installs kio in its own module.

image

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee @thiagokokada

@doronbehar
Copy link

There is also a NixOS module option qt.platformTheme. Perhaps kde should be added there as well?

https://github.com/NixOS/nixpkgs/blob/65484f88b2c2175b3d06a8b5fd199bb852eee5e3/nixos/modules/config/qt.nix#L9

@rycee rycee merged commit c6a5fbf into nix-community:master Dec 10, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented Dec 10, 2024

Thanks! Merged to master now 🙂

@alyraffauf alyraffauf deleted the qt-add-kio branch December 10, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants