Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kanshi dont write config in absence of nix settings #6198

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

teto
Copy link
Collaborator

@teto teto commented Dec 11, 2024

Description

kanshi always writes a config. Dont write if if in absence of nix settings.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@teto
Copy link
Collaborator Author

teto commented Dec 11, 2024

@GaetanLepage for review as you are a kanshi user

Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@teto teto force-pushed the teto/kanshi-no-config branch 2 times, most recently from 92c8b56 to 26bc4f9 Compare December 12, 2024 20:59
@teto teto force-pushed the teto/kanshi-no-config branch from 26bc4f9 to 49b3e38 Compare December 12, 2024 22:09
@teto teto merged commit 3066cc5 into nix-community:master Dec 12, 2024
3 checks passed
@teto teto deleted the teto/kanshi-no-config branch December 12, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants