break(nix): disable nix channels #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channels are not reproducible and should be removed. This change: * removes the `nix-channel` binary * sets an empty NIX_PATH * stop adding the /root/.nix-channels file This will lead scripts depending on channels to break, exposing their dependency on channels.
that unfortunately currently breaks things NixOS/nixpkgs#323613 |
|
With the pull request closed, is this now merge-able? NixOS/nixpkgs#323613 |
|
I believe it is! That PR was also backported, so we should be good with stable support. One think we could consider in another PR is to set NIX_PATH and flake registry.json entries for config.srvos.flake and config.srvos.flake.inputs.nixpkgs where config.srvos.flake is set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channels are not reproducible and should be removed.
This change:
nix-channelbinaryThis will lead scripts depending on channels to break, exposing their dependency on channels.