Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break(flake): use upstream options... #500

Merged
merged 1 commit into from
Sep 6, 2024
Merged

break(flake): use upstream options... #500

merged 1 commit into from
Sep 6, 2024

Conversation

phaer
Copy link
Member

@phaer phaer commented Sep 5, 2024

  • use nixpkgs.flake settings to add nixpkgs
  • drop symlink flake
  • replace it with registerSelf, which uses the flake registry
  • don't add all inputs of self anymore, they can quickly be referenced with self.inputs anyway.

@phaer
Copy link
Member Author

phaer commented Sep 5, 2024

I did no lib.mkRenamedOptionModule for symlinkFlake -> registerSelf, as it's not just a rename.

We say "stable" in the README, but we don't really have releases or anything to communicate
breaking changes yet, I think? Technically, there's another breaking change as this doesn't add all inputs of self anymore - on the main branch for a few days.

* use nixpkgs.flake settings to add nixpkgs
* drop symlink flake
* replace it with registerSelf, which uses the flake registry
* don't add all inputs of `self` anymore, they can quickly be
  referenced with `self.inputs` anyway.
@phaer phaer marked this pull request as ready for review September 5, 2024 08:54
@phaer phaer changed the title srvos.flake: use upstream options... break(flake): use upstream options... Sep 5, 2024
@zimbatm
Copy link
Member

zimbatm commented Sep 5, 2024

/cc @zowoq because he's been affected by this as well

@zowoq
Copy link
Contributor

zowoq commented Sep 5, 2024

/cc @zowoq because he's been affected by this as well

No, not affected by this, not using srvos.flake option.

@zimbatm
Copy link
Member

zimbatm commented Sep 5, 2024

Ok. I assumed because you were duplicating some of the stuff in nix-community/infra#1436

@phaer phaer requested review from Mic92 and zimbatm September 5, 2024 20:44
@phaer phaer merged commit b4e3c64 into main Sep 6, 2024
98 checks passed
@phaer phaer deleted the flake-registry branch September 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants