Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: use nix language server #16

Closed
wants to merge 2 commits into from
Closed

Conversation

JamieMagee
Copy link
Member

This PR replaces external calls to nixpkgs-fmt and nix-instantiate with the nix langage server

Currently, automatic detection or installation of the language server is not implemented

@jnoortheen Can you please checkout this branch, and test locally?

This PR replaces external calls to nixpkgs-fmt and nix-instantiate with the [nix langage server](https://github.com/nix-community/rnix-lsp)

Currently, automatic detection or installation of the language server is not implemented
@jnoortheen
Copy link
Collaborator

Thanks for the PR. I wanted to add it myself. Sure I will test it.

@jnoortheen
Copy link
Collaborator

jnoortheen commented Oct 14, 2020

@JamieMagee please consider my following change requests.

  • removing fable related files - I have removed the files

  • adding LSP --> the extension should detect rnix-lsp from path and use language server. If it is not available then the other functions should work as usual.

  • retaining the functionality of nixpkgs-fmt and nix-instantiate will help some. --> for the time being

@jnoortheen
Copy link
Collaborator

closes #10

@jnoortheen jnoortheen closed this Nov 30, 2020
@jnoortheen jnoortheen deleted the branch master November 30, 2020 08:14
jnoortheen added a commit that referenced this pull request Dec 23, 2020
closes #10

adapted code from
#16
thanks to @JamieMagee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants